(1) Remove OASIS XSL StyleSheets from GnuCash-docs Tree #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepared variables for build directory transition. Changed build directory creation timing. Fixed dependency.
Added missing OASIS xslt icons into xsl/images.
Put latest GnuCash-specific icons into xsl/icons.
Removed stylesheets/.
Changed CMake files related new directory structure.
Changed ${BUILDDIR} to ${CMAKE_CURRENT_BINARY_DIR}/${fmt} for CHM, PDF, and EPUB target.
Removed xsl/1.79.2/ completely. Removed unused customization files.
Fix target install for each format. Clean up unused variables.
FO and HTML have different formats, so you need to customize them appropriately depending on how docbook-xsl is written. Rewrote titlepage and variablelist for each format.
* US letter for C, * A4 for other languages. ISO A4 paper size is used worldwide but letter and legal size are mainly used in the US. Therefore paper size is set above. This setting should be moved CMake option in the future.
…pectively. CHM format uses traditional Windows codepages, not Unicode. Therefore traditional character code should be applied for the HTML and TOC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate #234
In this PR, OASYS XSL stylesheets from GnuCash-docs are removed completely.
522508d
Added an argument dtd_files to add_${fmt}_target and added dependency for DTD files.
Changed build directory creation timing from configuration to build.
Prepared variables for build directory transition.
Issue Fixed:
Dependency for language-specific DTD files is missing.
Create dependency for GnuCash-customized xsl files.
fcf64b3
Merged MakeChm.cmake into AddChmTarget.cmake.
Because functions of context-specific help for CHM are not used in GnuCash, the map section and alias section are removed.
d1134db
Added missing OASIS xslt icons into xsl/images.
Put latest GnuCash-specific icons into xsl/icons.
Removed stylesheets/.
Changed CMake files related the new directory structure.
Changed
B
U
I
L
D
D
I
R
t
o
{CMAKE_CURRENT_BINARY_DIR}/${fmt} for CHM, PDF, and EPUB target.
${BUILD_DIR} is changed in this commit in order to add target clean-extra in the future.
Additionally, the directory for the target ghelp is changed to share/help/${lang}/${docname}.
The location of output files may be changed here but will be restored later.
Issue Fixed:
Move contents of stylesheet/ to xsl/.
GnuCash-specific icons are wanted to be used.
Create dependency for GnuCash-specific icons.
Some admonition and callout icons are lacking.
Admonition icons directory is incorrect for chm.
d455af1 and 54962ae
Added new XSL structure without customization.
Applied new XSL files for each format.
Removed xsl/1.79.2/ completely.
Removed unused customization files.
Current customizations are removed but will be restored later
Issue Fixed:
Remove OASIS XSLT from xsl/1.79.2 and use system xsl files.
fe36eda and 9dbed25
Changed the layout of ${OUTPUT_DIR}.
Fix target install for each format.
Clean up unused variables.
The output location of PDF, EPUB, MOBI, and CHM is restored.
Issue Fixed:
Lacking dependency:
l
a
n
g
−
{docname}-mobi
l
a
n
g
−
{docname}-epub.
72ce9e2 and 14dd610
Restored customizations that don't have side effects.
Apply fixed titlepage and variablelist.
FO and HTML have different formats, so you need to customize them appropriately depending on how docbook-xsl is written.
Rewrote titlepage and variablelist for each format.
Issue Fixed:
Current variablelist.xsl breaks docbook-xsl multiple features, should be split for HTML and FO.
Customization of titlepage is not applied, should be split for HTML and FO.
Resolution of PNG admonition icons is too low. Use SVG instead.
Customize variable lists, PR #203.
046e895
Change paper size setting:
US letter for C,
A4 for other languages.
ISO A4 paper size is used worldwide but letter and legal size
are mainly used in the US. Therefore paper size is set above.
This setting should be moved CMake option in the future.
Issue Fixed:
Paper size for PDF is set USletter (except LANG C.)
f1945c8
Set character code Shift_JIS and KOI8-R for Japanese and Russian, respectively.
CHM format uses traditional Windows codepages, not Unicode. Therefore
traditional character code should be applied for the HTML and TOC.
Issue Fixed:
TOC of chm for ja and ru is not shown correctly.